Conversation
…tack/react-virtual Replace legacy react-virtualized (AutoSizer, List) with the hook-based useVirtualizer from @tanstack/react-virtual in the dynamic sampling projects table. - Remove row border :not(:last-child) selector since each row is now inside its own absolutely-positioned wrapper div - Replace InputCell styled component with Flex layout primitive - Remove cell gap to tighten spacing between project slug and description - Update BASE_ROW_HEIGHT to 63 to match actual measured row height - Mock getBoundingClientRect in tests for jsdom virtualizer support
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| </Cell> | ||
| <Cell> | ||
| <FirstCellLine> | ||
| <Flex direction="column" padding="xl xl md xl" style={{minWidth: 0}}> |
Contributor
There was a problem hiding this comment.
Last column top padding causes vertical content misalignment
Medium Severity
The last column uses padding="xl xl md xl" (16px top), while the first three columns use padding="md xl" (8px top). In the old code, all four columns shared the same Cell with identical padding: space(1) space(2) (8px 16px). This asymmetry causes the PercentInput and its FirstCellLine to sit 8px lower than the corresponding content (project badge, accepted spans, stored spans) in the other columns, creating a visible vertical misalignment across the row.
Additional Locations (1)
1 task
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 24, 2026
…nstack (#108277) Replace legacy react-virtualized (AutoSizer, List) with the hook-based useVirtualizer from @tanstack/react-virtual in the dynamic sampling projects table. - Remove row border :not(:last-child) selector since each row is now inside its own absolutely-positioned wrapper div - Remove cell gap to tighten spacing between project slug and description - Replace some styles with layout components
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…nstack (#108277) Replace legacy react-virtualized (AutoSizer, List) with the hook-based useVirtualizer from @tanstack/react-virtual in the dynamic sampling projects table. - Remove row border :not(:last-child) selector since each row is now inside its own absolutely-positioned wrapper div - Remove cell gap to tighten spacing between project slug and description - Replace some styles with layout components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Replace legacy react-virtualized (AutoSizer, List) with the hook-based useVirtualizer from @tanstack/react-virtual in the dynamic sampling projects table.