Skip to content

feat(settings): Migrate dynamic sampling from react-virtualized to tanstack#108277

Merged
scttcper merged 4 commits intomasterfrom
scttcper/migrate-projects-table-tanstack-virtual
Feb 20, 2026
Merged

feat(settings): Migrate dynamic sampling from react-virtualized to tanstack#108277
scttcper merged 4 commits intomasterfrom
scttcper/migrate-projects-table-tanstack-virtual

Conversation

@scttcper
Copy link
Copy Markdown
Member

Replace legacy react-virtualized (AutoSizer, List) with the hook-based useVirtualizer from @tanstack/react-virtual in the dynamic sampling projects table.

  • Remove row border :not(:last-child) selector since each row is now inside its own absolutely-positioned wrapper div
  • Remove cell gap to tighten spacing between project slug and description
  • Replace some styles with layout components

…tack/react-virtual

Replace legacy react-virtualized (AutoSizer, List) with the hook-based
useVirtualizer from @tanstack/react-virtual in the dynamic sampling
projects table.

- Remove row border :not(:last-child) selector since each row is now
  inside its own absolutely-positioned wrapper div
- Replace InputCell styled component with Flex layout primitive
- Remove cell gap to tighten spacing between project slug and description
- Update BASE_ROW_HEIGHT to 63 to match actual measured row height
- Mock getBoundingClientRect in tests for jsdom virtualizer support
@scttcper scttcper requested a review from a team February 13, 2026 23:23
@scttcper scttcper requested a review from a team as a code owner February 13, 2026 23:23
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 13, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

</Cell>
<Cell>
<FirstCellLine>
<Flex direction="column" padding="xl xl md xl" style={{minWidth: 0}}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last column top padding causes vertical content misalignment

Medium Severity

The last column uses padding="xl xl md xl" (16px top), while the first three columns use padding="md xl" (8px top). In the old code, all four columns shared the same Cell with identical padding: space(1) space(2) (8px 16px). This asymmetry causes the PercentInput and its FirstCellLine to sit 8px lower than the corresponding content (project badge, accepted spans, stored spans) in the other columns, creating a visible vertical misalignment across the row.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Member

@ArthurKnaus ArthurKnaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for migrating! 🙌

@scttcper scttcper merged commit 2f9f30a into master Feb 20, 2026
62 checks passed
@scttcper scttcper deleted the scttcper/migrate-projects-table-tanstack-virtual branch February 20, 2026 19:26
priscilawebdev pushed a commit that referenced this pull request Feb 24, 2026
…nstack (#108277)

Replace legacy react-virtualized (AutoSizer, List) with the hook-based
useVirtualizer from @tanstack/react-virtual in the dynamic sampling
projects table.

- Remove row border :not(:last-child) selector since each row is now
inside its own absolutely-positioned wrapper div
- Remove cell gap to tighten spacing between project slug and
description
- Replace some styles with layout components
mchen-sentry pushed a commit that referenced this pull request Feb 24, 2026
…nstack (#108277)

Replace legacy react-virtualized (AutoSizer, List) with the hook-based
useVirtualizer from @tanstack/react-virtual in the dynamic sampling
projects table.

- Remove row border :not(:last-child) selector since each row is now
inside its own absolutely-positioned wrapper div
- Remove cell gap to tighten spacing between project slug and
description
- Replace some styles with layout components
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

claude-code-assisted Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants