feat(webhooks): Log slow forwarding & more context#108220
Merged
Conversation
This adds a log to help us find webhooks which were slow to be forwarded and add extra context to all logs.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Feb 13, 2026
| **cls.get_attributes_from_request(request), | ||
| ) | ||
|
|
||
| def as_dict(self) -> dict[str, Any]: |
Member
Author
There was a problem hiding this comment.
This will now be used for all logging in the module so we can slice the logs with these values.
| metrics.timing("hybridcloud.deliver_webhooks.delivery_time", duration.total_seconds()) | ||
| metrics.incr("hybridcloud.deliver_webhooks.delivery", tags={"outcome": "ok"}) | ||
| if duration >= SLOW_DELIVERY_THRESHOLD: | ||
| logger.warning("deliver_webhook.slow_delivery", extra=payload.as_dict()) |
Member
Author
There was a problem hiding this comment.
This is the new log I'm adding so we can debug.
billyvg
reviewed
Feb 13, 2026
suejungshin
approved these changes
Feb 13, 2026
markstory
approved these changes
Feb 13, 2026
billyvg
approved these changes
Feb 13, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…ogging Fixes a bug where payload.as_dict() and payload.date_added were accessed after payload.delete(), causing id and other fields to be null in log output. Capture payload_data and date_added before deletion in both deliver_message and _handle_parallel_delivery_result. Co-authored-by: Cursor <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Co-authored-by: Cursor <[email protected]>
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
This adds a log to help us find webhooks which were slow to be forwarded and add extra context to all logs. --------- Co-authored-by: Cursor <[email protected]>
1 task
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
This adds a log to help us find webhooks which were slow to be forwarded and add extra context to all logs. --------- Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a log to help us find webhooks which were slow to be forwarded and add extra context to all logs.