Skip to content

feat(aci): Translate issue category condition include property for legacy models#107948

Merged
malwilley merged 1 commit intomasterfrom
malwilley/feat/translate-issue-category-condition-include-property-for-legacy-models
Feb 10, 2026
Merged

feat(aci): Translate issue category condition include property for legacy models#107948
malwilley merged 1 commit intomasterfrom
malwilley/feat/translate-issue-category-condition-include-property-for-legacy-models

Conversation

@malwilley
Copy link
Copy Markdown
Member

Followup to #107527

Need these translators in order to use the include property in the old UI

@malwilley malwilley requested a review from a team as a code owner February 10, 2026 18:18
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 10, 2026
Copy link
Copy Markdown
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

}
include = data_condition.comparison.get("include")
if isinstance(include, bool):
payload["include"] = include
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 not sure if it's relevant anymore with some changes to processing, but should we also make sure the legacy models / system could use this? (only required if we go back to legacy processing, i think that code got deleted yesterday / friday kind of thing tho)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one followup PR I'm opening in a minute that I believe is all we need

@malwilley malwilley merged commit 8aad5fa into master Feb 10, 2026
74 checks passed
@malwilley malwilley deleted the malwilley/feat/translate-issue-category-condition-include-property-for-legacy-models branch February 10, 2026 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants