Conversation
malwilley
changed the title
github-actions
bot
added
the
Scope: Frontend
malwilley
force-pushed
the
malwilley/feat/update-frontend-redirects-to-use-metric-issues-flag-as-well
branch
from
8632e75 to
28595bf
Compare
…o-use-metric-issues-flag-as-well
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| features: ['workflow-engine-ui', 'workflow-engine-redirect-opt-out'], | ||
| }); | ||
|
|
||
| const Wrapped = withAutomationEditRedirect(TestComponent); |
There was a problem hiding this comment.
Test uses wrong HOC in describe block
Low Severity
Inside the describe('withAutomationDetailsRedirect') block, the opt-out test at line 69 wraps TestComponent with withAutomationEditRedirect instead of withAutomationDetailsRedirect. This means withAutomationDetailsRedirect's opt-out behavior is never actually tested. Both HOCs share the same underlying withRuleRedirect logic so the test passes, but it creates false confidence in coverage and won't catch a regression if withAutomationDetailsRedirect is changed independently.
malwilley
deleted the
malwilley/feat/update-frontend-redirects-to-use-metric-issues-flag-as-well
branch
…-metric-issue-ui flag (#107645)
…-metric-issue-ui flag (#107645)
2 participants
Closes ISWF-1940
The goal of this PR is that, when the user has the
workflow-engine-metric-issues-uiflag, clicking metric alert notifications will redirect to the corresponding metric issue.I added a new HOC for this called
Cursor Bugbot reviewed your changes and found no issues for commit 28595bfwithMetricIssueRedirect(). While added this, I saw an opportunity to reuse some logic and make the existing HOCs a bit more readable. I also added a bunch of tests to verify that everything still redirects as expected.