feat(aci): add exclusion to issue category filter #107527
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
src/sentry/workflow_engine/handlers/condition/issue_category_handler.py
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
src/sentry/workflow_engine/handlers/condition/issue_category_handler.py
Outdated
Show resolved
Hide resolved
| if include: | ||
| return bool(value == issue_category or value == issue_category_v2) | ||
|
|
||
| return bool(value != issue_category or value != issue_category_v2) |
There was a problem hiding this comment.
I think the bots are right about this
There was a problem hiding this comment.
Ah, De Morgan's Law 😅
| "type": "object", | ||
| "properties": { | ||
| "value": {"type": "integer", "enum": [*GroupCategory]}, | ||
| "type": {"type": "boolean"}, |
There was a problem hiding this comment.
Why do we add bool as a type here?
There was a problem hiding this comment.
🤔 maybe naming this notify_on_deescalation would make more sense? (i believe this is the config to determine if users should be notified about the issue on de-escalation as well)
There was a problem hiding this comment.
Oh I think I just misunderstood... this is just whether we should include or exclude these issue categories right? So probably we should call it include or exclude?, since that's how we refer to it in code.
There was a problem hiding this comment.
include makes sense to me, I will change it!
We want to allow users to exclude certain issue categories.
We want to allow users to exclude certain issue categories.
3 participants
We want to allow users to exclude certain issue categories.