Conversation
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
malwilley
force-pushed
the
malwilley/feat/update-metric-issue-open-periods-list-to-use-activities
branch
from
8df6b5f to
d181989
Compare
malwilley
commented
Feb 3, 2026
| query: params, | ||
| query: { | ||
| ...params, | ||
| per_page: limit, |
Member
Author
There was a problem hiding this comment.
The limit wasn't being sent properly before this change
scttcper
reviewed
Feb 3, 2026
| const data: OpenPeriodDisplayData[] = openPeriods.flatMap(period => { | ||
| const periodActivities = orderBy( | ||
| period.activities.filter(activity => activity.type !== 'closed'), | ||
| 'dateCreated', |
Member
Author
There was a problem hiding this comment.
yeah but it's ISO so still sortable as a string
Member
There was a problem hiding this comment.
didn't realize you like to live mas
scttcper
approved these changes
Feb 3, 2026
malwilley
deleted the
malwilley/feat/update-metric-issue-open-periods-list-to-use-activities
branch
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref ISWF-1983
Prior to this we were only showing events that created a new open period, not subsequent events which changed the priority. I'm not sure if this is the final design we will go with, but it does at least show all the events correctly now.
Note that
eventIdwill not show up for all activities yet until some other PRs are merged.