feat(code-review): Register experiments feature flag#107478
feat(code-review): Register experiments feature flag#107478giovanni-guidini merged 2 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
giovanni-guidini
force-pushed
the
feat/cw-696-port-experiments-flag
branch
from
7256e14 to
853d51f
Compare
| return features.has( | ||
| "organizations:code-review-experiments-enabled", | ||
| organization, | ||
| actor=user, |
There was a problem hiding this comment.
I was told by Claude that this is not used to hash the feature decision (e.g. assignment to experiment or not isn't affected by who opened the PR)
There was a problem hiding this comment.
You don't need the user unless you intend to control experiments to specific Sentry users.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
armenzg
left a comment
armenzg
left a comment
There was a problem hiding this comment.
Do we intend to add some information in the event payload sent to Seer?
| return features.has( | ||
| "organizations:code-review-experiments-enabled", | ||
| organization, | ||
| actor=user, |
There was a problem hiding this comment.
You don't need the user unless you intend to control experiments to specific Sentry users.
Just that boolean field (#107483) |
Ports only the feature flag from PR #107230 to control org-level eligibility for code review experiments. Per the updated architecture decision in CW-696, the option registration and hash bucket assignment logic will be moved directly to Seer. This allows Seer to test sentry-options integration directly while keeping the monolith implementation minimal. Refs CW-696
* move flag lookup from `assignemnt.py` to `utils.py` * moved the tests too
giovanni-guidini
force-pushed
the
feat/cw-696-port-experiments-flag
branch
from
853d51f to
e4aef30
Compare
|
looks like #107483 will need a merge after this lands. |
armenzg
left a comment
armenzg
left a comment
There was a problem hiding this comment.
Thank you for addressing all feedback!
Adds a new feature flag that will be used by code-review to check eligibility for A/B test experiments.
3 participants
Summary
Ports only the feature flag from PR #107230 to control org-level eligibility for code review experiments.
This PR implements the simplified architecture decided in CW-696 (see latest comment 2026-02-03):
organizations:code-review-experiments-enabledfor org eligibility controlcode-review.experiments(moved to Seer)Context
The original PR #107230 included both the feature flag and the assignment logic in the monolith. Based on team feedback, we've simplified the implementation:
sentry-optionsintegration directly while keeping the monolith minimalChanges
organizations:code-review-experiments-enabledfeature flag insrc/sentry/features/temporary.pyFLAGPOLEstrategy withapi_expose=False(internal use only)Test Plan
References