feat(aci): Add sorting for connected alerts#106109
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
saponifi3d
approved these changes
Jan 12, 2026
Contributor
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
my comments are just nits about the simple table component 🤣 -- these changes lgtm
| const detectorIds = [detectorId, issueStreamDetectorId]; | ||
| const [cursor, setCursor] = useState<string | undefined>(undefined); | ||
| const [searchQuery, setSearchQuery] = useState(''); | ||
| const [triggeredBySort, setTriggeredBySort] = useState<'asc' | 'desc'>('desc'); |
Contributor
There was a problem hiding this comment.
nit / future -- should this be a literal that we get from the table? (would be cool to have all this built into the table component then we can somehow customize it)
Comment on lines
+91
to
+92
| const handleTriggeredBySort = useCallback(() => { | ||
| setTriggeredBySort(sort => (sort === 'asc' ? 'desc' : 'asc')); |
Contributor
There was a problem hiding this comment.
nit: it'd be cool if the component returned the sort direction in the callback.
Member
Author
There was a problem hiding this comment.
True that would be better! I can make that change in another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new API query param to sort directly connected detectors at the top: #105976