Skip to content

feat(aci): Workflow API sort by priority detector ID#105976

Merged
malwilley merged 2 commits intomasterfrom
malwilley/feat/add-workflow-sort-by-priority-detector-id
Jan 12, 2026
Merged

feat(aci): Workflow API sort by priority detector ID#105976
malwilley merged 2 commits intomasterfrom
malwilley/feat/add-workflow-sort-by-priority-detector-id

Conversation

@malwilley
Copy link
Copy Markdown
Member

@malwilley malwilley commented Jan 8, 2026 •
edited
Loading

In order to support the new designs which allow sorting for workflows that are either directly connected or connected via project detectors, we need some way to prioritize a certain detector ID.

This is a bit unconventional, but it adds support for /workflows/?priorityDetector=123 which will sort the list with workflows connected to detector 123 at the top.

@malwilley malwilley requested a review from a team as a code owner January 8, 2026 23:34
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 8, 2026
wedamija
wedamija reviewed Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a secondary sort? Everything below the priority detector will be arbitrary otherwise.

I think that the priority detector id should probably be a separate query param rather than embedded in the sort string

@wedamija
Copy link
Copy Markdown
Member

wedamija commented Jan 9, 2026

Should this have a secondary sort? Everything below the priority detector will be arbitrary otherwise.

I think that the priority detector id should probably be a separate query param rather than embedded in the sort string

Actually... should priority detector id just be a separate param, and if present, sort all of those workflows at the top. Then you can set the other sort as normal. That way you can say "give me detector 1 workflows as priority, and sort them by last triggered". and then all non-priority detectors also get sorted in that way, after the priority sort

@malwilley malwilley force-pushed the malwilley/feat/add-workflow-sort-by-priority-detector-id branch from 04ae6d4 to 3c5ec67 Compare January 9, 2026 17:09
@malwilley
Copy link
Copy Markdown
Member Author

malwilley commented Jan 9, 2026

@wedamija okay yeah I think I like it better with it as a separate query param since it is a bit wonky as a sort. Changed to add priorityDetector=<id>

@malwilley malwilley requested a review from wedamija January 9, 2026 17:10
@malwilley malwilley requested a review from a team January 9, 2026 18:01
@malwilley malwilley merged commit 8bf54e0 into master Jan 12, 2026
67 checks passed
@malwilley malwilley deleted the malwilley/feat/add-workflow-sort-by-priority-detector-id branch January 12, 2026 17:03
@malwilley malwilley mentioned this pull request Jan 12, 2026
Merged
@github-actions github-actions bot mentioned this pull request Jan 13, 2026
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wedamija wedamija wedamija approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@malwilley @wedamija