Does this ever happen, or is it just for safety? Maybe this check should exist outside of this handler so that it doesn't result in a dead click? Depending on the usage, I would probably propose something like this

<Button disabled={!!externalIssue} ... />

function openSentryAppIssueModal(options){
  if(!options.externalissue) throw new Error(...)
}

i'm not sure it was just there before, just co-locating the function

removed, we check for this already in the new flow

row is default so this is unnecessary, but it doesn't really matter tbh as being explicit is also nice

yeah its what they used in this pr but i'm moving it here https://github.com/getsentry/sentry/pull/99177/changes#diff-dbd3815b3ce60dea1f2a8c03526c30f3a4ab685b7cf8fe43ec51287adf77d3e7R92

Success message callback ignored due to type mismatch

Medium Severity

The openExternalIssueModal function declares onChange with type () => void, but ExternalIssueForm internally expects onChange to accept callback parameters and calls onChange(() => addSuccessMessage(MESSAGES_BY_ACTION[action])). Since refetchIntegrations is passed as onChange and it doesn't accept callback arguments, the success callback is silently ignored. Users won't see the "Successfully linked issue." or "Successfully created issue." toast messages after creating or linking external issues.