feat(dashboards): create prebuilt dashboard for backend overview#105719
Conversation
DominikB2014
commented
Jan 6, 2026
DominikB2014
commented
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/dashboards/utils/prebuiltConfigs/backendOverview/backendOverview.ts
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/utils/prebuiltConfigs/backendOverview/backendOverview.ts
Show resolved
Hide resolved
static/app/views/dashboards/utils/prebuiltConfigs/backendOverview/backendOverview.ts
Show resolved
Hide resolved
static/app/views/dashboards/utils/prebuiltConfigs/backendOverview/backendOverview.ts
Show resolved
Hide resolved
static/app/views/dashboards/utils/prebuiltConfigs/backendOverview/backendOverview.ts
Show resolved
Hide resolved
| name: '', | ||
| fields: [ | ||
| SpanFields.TRANSACTION, | ||
| 'equation|count_if(cache.hit,equals,false)', |
There was a problem hiding this comment.
Hardcoded field name inconsistent with SpanFields constant usage
Low Severity
The field cache.hit is hardcoded as a string on this line, while the rest of the file (lines 175 and 268) consistently uses SpanFields.CACHE_HIT for the same field. If SpanFields.CACHE_HIT is ever renamed or its value changes, this hardcoded occurrence would be missed and cause the widget query to break. Using ${SpanFields.CACHE_HIT} would maintain consistency and prevent future maintenance issues.
| 'Time Spent', | ||
| ], | ||
| conditions: TABLE_QUERY.formatString(), | ||
| orderby: '-sum(span.duration)', |
There was a problem hiding this comment.
Hardcoded span.duration inconsistent with SpanFields constant usage
Low Severity
The orderby value uses a hardcoded string 'span.duration' while the same field in the fields and aggregates arrays on lines 300-304 and 308-312 consistently uses SpanFields.SPAN_DURATION. If the SpanFields.SPAN_DURATION constant value ever changes, this ordering clause would break while the rest of the query would use the updated value, causing the widget to fail or sort incorrectly.
DominikB2014
deleted the
dominikbuszowiecki/browse-216-create-basic-backend-overview-page
branch
2 participants
