feat(issues): Add stack trace, tags to top issues#105466
Merged
Conversation
adds tags and an example stack trace to the single card layout. Currently you would need to click view all issues -> pick issue to see a stack trace or tags. I think adding a bit of aggregate data helps someone other than seer decide what the fix looks like
| function useClusterEventsStats(groupIds: number[], statsPeriod: StatsPeriod) { | ||
| const organization = useOrganization(); | ||
|
|
||
| const interval = statsPeriod === '7d' ? '1d' : '1d'; |
Contributor
There was a problem hiding this comment.
Redundant ternary always returns same interval value
The ternary expression statsPeriod === '7d' ? '1d' : '1d' always evaluates to '1d' regardless of the condition. Both branches return the same value, making the conditional pointless. This appears to be incomplete code where different intervals were likely intended for different stat periods (e.g., '6h' for 7-day views vs '1d' for 30-day views). Currently only '30d' is passed to this function, so there's no immediate production impact, but this would cause unexpected behavior if '7d' support is added later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds tags and an example stack trace to the single card layout. Currently you would need to click view all issues -> pick issue to see a stack trace or tags. I think adding a bit of aggregate data helps someone other than seer decide what the fix looks like