feat(build-comparison): Synchronizes the hide small changes switch with a url query param to ensure state is preserved in browser history#105234
Merged
cameroncooke merged 1 commit intomasterfrom Dec 19, 2025
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
static/app/views/preprod/buildComparison/main/sizeCompareMainContent.tsx
Outdated
Show resolved
Hide resolved
cameroncooke
force-pushed
the
cameroncooke/eme-437-add-hide-small-changes-to-url-state
branch
from
0c86997 to
36ef0ad
Compare
…ameter management (EME-437) Added the UrlParamBatchProvider to the BuildComparison component to manage URL query parameters effectively. Updated SizeCompareMainContent to utilize useQueryParamState for handling the 'hideSmallChanges' parameter, improving state management and user experience when toggling visibility of small changes in the comparison view.
cameroncooke
force-pushed
the
cameroncooke/eme-437-add-hide-small-changes-to-url-state
branch
from
36ef0ad to
3dc0f70
Compare
chromy
approved these changes
Dec 19, 2025
Contributor
chromy
left a comment
chromy
left a comment
There was a problem hiding this comment.
lgtm, Thanks!
Commit title might need adjusting when you land this, the PR title still references UrlParamBatchProvider
cameroncooke
changed the title
cameroncooke
deleted the
cameroncooke/eme-437-add-hide-small-changes-to-url-state
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
SizeCompareMainContentcomponent to improve how the "hide small changes" state is managed and synchronized with the URL. The changes ensure that the state persists in the URL, allowing for better navigation and sharing of filtered views.State management and URL synchronization improvements:
useStateforhideSmallChangeswithuseQueryStatefromnuqs, synchronizing the state with the URL query parameter and providing a default value oftrue. [1] [2]disableHideSmallChangeshandler to explicitly sethideSmallChangestofalse, ensuring consistent behavior with the new state management approach.