feat(code-review): Add overwatch repo settings rpc#104744
feat(code-review): Add overwatch repo settings rpc#104744suejung-sentry merged 7 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
suejung-sentry
force-pushed
the
sshin/code-review-ow
branch
3 times, most recently
from
6d9b353 to
078c6a0
Compare
suejung-sentry
force-pushed
the
sshin/code-review-ow
branch
from
078c6a0 to
8ec5f14
Compare
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
| re_path( | ||
| r"^code-review/repo-settings/$", | ||
| CodeReviewRepoSettingsEndpoint.as_view(), | ||
| name="sentry-api-0-code-review-repo-settings", |
There was a problem hiding this comment.
This rpc will replace the existing PreventPrReviewSentryOrgEndpoint which we can delete when ready.
Setting this up here as a sibling to allow for backwards compatible cutover
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104744 +/- ##
===========================================
+ Coverage 80.49% 80.53% +0.03%
===========================================
Files 9370 9353 -17
Lines 402244 401334 -910
Branches 25843 25743 -100
===========================================
- Hits 323781 323199 -582
+ Misses 78015 77695 -320
+ Partials 448 440 -8 |
3 participants
We're saving code review settings to new table
sentry_repositorysettings- have overwatch service read the values from here in its rpc call instead of the data returned at the old existing endpoint (PreventPrreviewSentryOrgEndpoint). We can deprecate that one once we're done cutting over to the new one.Closes https://linear.app/getsentry/issue/ENG-6098