feat(preprod): record if the status check failed#104039
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
noahsmartin
reviewed
Nov 26, 2025
noahsmartin
reviewed
Nov 26, 2025
tests/sentry/preprod/vcs/status_checks/size/test_status_checks_tasks.py
Outdated
Show resolved
Hide resolved
noahsmartin
reviewed
Nov 26, 2025
|
|
||
| posted_status_checks = extras.get("posted_status_checks", {}) | ||
|
|
||
| check_result: dict[str, Any] = {"success": success} |
Contributor
There was a problem hiding this comment.
minor but you could move these lines out of the transaction
noahsmartin
approved these changes
Nov 26, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104039 +/- ##
===========================================
+ Coverage 77.47% 80.60% +3.13%
===========================================
Files 9316 9318 +2
Lines 397607 397582 -25
Branches 25398 25379 -19
===========================================
+ Hits 308032 320480 +12448
+ Misses 88907 76650 -12257
+ Partials 668 452 -216 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records in the
extrasfield whether the status check succeeded or not, which we can later display in the UI.