curious about the !user.isStaff piece here, is that so we can continue with everything as is today w/o redirecting? might be nice to just have staff use the same experience; and this could be a nice forcing function for everyone to dog food this before we flip the LA switch.

Adding the isStaff check makes it easier for us to compare the old vs. new experience while developing, so I'd like to keep this check for now

nit: recommend against having nested ternaries, makes readability even with these indentations a bit tricky.

Maybe something like:

const getDetectionType = (alertType: string): string => {
  switch(alertType) {
    case 'crons':
      return 'monitor_check_in_failure';
    case 'uptime':
      return 'uptime_domain_failure';
    default:
      return null;
  }
}

// in use
const detectorType = getDetectionType(alertType);

this makes it a little easier to quickly read, but also makes it a lot easier to add a 3rd type if we need to or anything.

import should still be lazy

can we make this a hook (or small HoCish wrapper for class components) and wrap the areas we want to redirect instead. Adding these to the route tree doesn't totally make sense if they aren't views

This can't be a hook because it needs to render the loading state while the requests are in flight, but it could be an HoC. That would feel cleaner and wouldn't require changing the route tree

i think that's where i'm at yeah this shouldn't need to be in the route tree

Unfortunately this isn't completely lazy, you need to make a new file with a default export that is export default withDetectorDetailsRedirect(MetricDetails)

Bug: Redirect occurs without valid alert type

The withDetectorCreateRedirect function redirects to the monitor create page even when alertType is undefined or doesn't map to a valid detector type. When getDetectionType returns null, the code still performs a redirect to makeMonitorCreatePathname(organization.slug) without the detector type query parameter. This causes routes like wizard/ and :projectId/ (which don't have an alertType parameter) to incorrectly redirect when the feature flag is enabled. The redirect should only occur when detectorType is not null.