Skip to content

feat(performance): Updates Web Vitals issue detection to consolidate lcp, fcp, and ttfb into a single issue#103272

Merged
edwardgou-sentry merged 7 commits intomasterfrom
egou/feat/web-vitals-issue-detection-consolidate-vitals
Nov 14, 2025
Merged

feat(performance): Updates Web Vitals issue detection to consolidate lcp, fcp, and ttfb into a single issue#103272
edwardgou-sentry merged 7 commits intomasterfrom
egou/feat/web-vitals-issue-detection-consolidate-vitals

Conversation

@edwardgou-sentry
Copy link
Copy Markdown
Contributor

@edwardgou-sentry edwardgou-sentry commented Nov 12, 2025 •
edited
Loading

LCP, FCP, and TTFB issues often share similar root causes and fixes when analyzed by Seer. To reduce duplicate similar issues, updates Web Vitals issue detection to consolidate low LCP, FCP, and TTFB scores into a single rendering grouping/fingerprint.

  • Slightly changes issue event tags to support this. Each web vital score and value is stored as its own tag on the issue event.
  • The trace sample for the event is the p75 sample chosen from the worst scoring vital.
  • Slight change to title and subtitle generation (this will likely be replaced in a separate pr for further title improvement)

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 12, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 12, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
29666 1 29665 243
View the top 1 failed test(s) by shortest run time 
tests.sentry.tasks.test_web_vitals_issue_detection.WebVitalsIssueDetectionDataTest::test_run_detection_groups_rendering_vitals
Stack Traces | 5.28s run time 
#x1B[1m#x1B[.../sentry/tasks/test_web_vitals_issue_detection.py#x1B[0m:336: in test_run_detection_groups_rendering_vitals
    assert lcp_occurrence.issue_title == "Rendering score needs improvement"
#x1B[1m#x1B[31mE   AssertionError: assert 'Render time ...d improvement' == 'Rendering sc...s improvement'#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     - Rendering score needs improvement#x1B[0m
#x1B[1m#x1B[31mE     ?        ^^           -#x1B[0m
#x1B[1m#x1B[31mE     + Render time Web Vital scores need improvement#x1B[0m
#x1B[1m#x1B[31mE     ?       ++ ^^^^^^^^^^^^      +#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review November 13, 2025 03:47
@edwardgou-sentry edwardgou-sentry requested a review from a team November 13, 2025 03:47
cursor[bot]
cursor bot reviewed Nov 13, 2025
View reviewed changes
@edwardgou-sentry
Merge branch 'master' of github.com:getsentry/sentry into egou/feat/w…
076eec9 
…eb-vitals-issue-detection-consolidate-vitals
@edwardgou-sentry edwardgou-sentry merged commit 829de88 into master Nov 14, 2025
66 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/web-vitals-issue-detection-consolidate-vitals branch November 14, 2025 20:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@mjq mjq mjq approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edwardgou-sentry @mjq