feat(billing): use Subscription.orgRetention in customerOverview#103124
feat(billing): use Subscription.orgRetention in customerOverview#103124
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| {customer.dataRetention || '90d'} | ||
| {customer.orgRetention?.standard | ||
| ? `${customer.orgRetention?.standard}d` | ||
| : '90d'} |
There was a problem hiding this comment.
what's the reason we fallback to 90d?
There was a problem hiding this comment.
Good catch. This is actually an existing bug, because we show 90-day retention for free orgs.
It should fall back to the errors retention for the org (all plans have DataCategory.ERROR), and then perhaps fall back to 90.
github-actions
bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
vbro
force-pushed
the
vbro_use_orgretention_in_cust_overview
branch
from
d98ac3d to
04ad2e9
Compare
vbro
force-pushed
the
vbro_use_orgretention_in_cust_overview
branch
from
04ad2e9 to
1080a50
Compare
2 participants
This PR is stack on top of #103118 and is a follow up to https://github.com/getsentry/getsentry/pull/18799