chore(sub v3): prep for EA#101437
Merged
isabellaenriquez merged 6 commits intomasterfrom Oct 15, 2025
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
Comment on lines
+37
to
+43
| for (let i = routes.length - 1; i >= 0; i--) { | ||
| const route = routes[i] as RouteWithName; | ||
| if (route?.name) { | ||
| feedbackSource = route.name; | ||
| break; | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
the route name we desire for feedbackSource is always the last route in routes with a name
dashed
approved these changes
Oct 14, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| subscription, | ||
| addOnCategory: row.addOnCategory, | ||
| isOpen: !!isOpen, | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: Add-on Toggle Analytics Event Tracks Incorrect State
The subscription_page.usage_overview.add_on_toggled analytics event reports an incorrect isOpen value. Due to asynchronous state updates, the event tracks the opposite of the actual add-on toggle action.
chromy
pushed a commit
that referenced
this pull request
Oct 17, 2025
- Start replay recording every time any of the Usage & Billing settings pages are navigated to - Remove `trackSubscriptionView`; this event has been removed and we can use the automated Page View events instead - Add route analytics param for whether the page view is with the new UI flag - Automatically add analytics params for new checkout and new UI for all events defined in `trackGetsentryAnalytics`, instead of needing to manually add these flags for every relevant event - Adds some missing analytics events - Add feedback form button to every Usage & Billing settings page Closes BIL-1594, BIL-1595, and BIL-1640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trackSubscriptionView; this event has been removed and we can use the automated Page View events insteadtrackGetsentryAnalytics, instead of needing to manually add these flags for every relevant eventCloses BIL-1594, BIL-1595, and BIL-1640