fix(dashboards): Move axisRange defaulting out of converter into edit call site

mtopo27 · claude · mtopo27 · commit f6a68c7e958f · 2026-02-27T15:28:49.000-05:00
The shared converter was injecting axisRange: 'auto' for every caller,
breaking discover tests that don't expect it. Move the default to the
only call site that needs it: editing an existing widget in detail.tsx.

Co-Authored-By: Claude &lt;noreply@anthropic.com&gt;
diff --git a/static/app/views/dashboards/detail.tsx b/static/app/views/dashboards/detail.tsx
@@ -704,7 +704,10 @@ class DashboardDetail extends Component<Props, State> {
         pathname: path,
         query: {
           ...location.query,
-          ...convertWidgetToBuilderStateParams(widget),
+          ...convertWidgetToBuilderStateParams({
+            ...widget,
+            axisRange: widget.axisRange ?? 'auto',
+          }),
         },
       }),
       {preventScrollReset: true}
diff --git a/static/app/views/dashboards/widgetBuilder/utils/convertWidgetToBuilderStateParams.spec.tsx b/static/app/views/dashboards/widgetBuilder/utils/convertWidgetToBuilderStateParams.spec.tsx
@@ -123,7 +123,7 @@ describe('convertWidgetToBuilderStateParams', () => {
     );
   });
 
-  it('defaults axisRange to auto when widget axisRange is null', () => {
+  it('returns undefined axisRange when widget axisRange is null', () => {
     const widget = {
       ...getDefaultWidget(WidgetType.ERRORS),
       axisRange: null,
@@ -132,10 +132,10 @@ describe('convertWidgetToBuilderStateParams', () => {
     const params = convertWidgetToBuilderStateParams(
       widget as unknown as Parameters<typeof convertWidgetToBuilderStateParams>[0]
     );
-    expect(params.axisRange).toBe('auto');
+    expect(params.axisRange).toBeUndefined();
   });
 
-  it('defaults axisRange to auto when widget axisRange is invalid', () => {
+  it('returns undefined axisRange when widget axisRange is invalid', () => {
     const widget = {
       ...getDefaultWidget(WidgetType.ERRORS),
       axisRange: 'invalid',
@@ -144,7 +144,7 @@ describe('convertWidgetToBuilderStateParams', () => {
     const params = convertWidgetToBuilderStateParams(
       widget as unknown as Parameters<typeof convertWidgetToBuilderStateParams>[0]
     );
-    expect(params.axisRange).toBe('auto');
+    expect(params.axisRange).toBeUndefined();
   });
 
   describe('traceMetric', () => {
diff --git a/static/app/views/dashboards/widgetBuilder/utils/convertWidgetToBuilderStateParams.ts b/static/app/views/dashboards/widgetBuilder/utils/convertWidgetToBuilderStateParams.ts
@@ -76,6 +76,6 @@ export function convertWidgetToBuilderStateParams(
     selectedAggregate: firstWidgetQuery?.selectedAggregate,
     thresholds: widget.thresholds ? serializeThresholds(widget.thresholds) : undefined,
     traceMetric: traceMetric ? serializeTraceMetric(traceMetric) : undefined,
-    axisRange: getAxisRange(widget.axisRange) ?? 'auto',
+    axisRange: getAxisRange(widget.axisRange),
   };
 }
diff --git a/static/app/views/discover/utils.spec.tsx b/static/app/views/discover/utils.spec.tsx
@@ -872,7 +872,6 @@ describe('constructAddQueryToDashboardLink', () => {
         displayType: DisplayType.AREA,
         yAxis: ['count()', 'count_unique(user)'],
         source: DashboardWidgetSource.DISCOVERV2,
-        axisRange: 'auto',
       });
     });
     it('should construct a link with the correct params - topN', () => {
@@ -905,7 +904,6 @@ describe('constructAddQueryToDashboardLink', () => {
         yAxis: ['count()'],
         limit: 5,
         source: DashboardWidgetSource.DISCOVERV2,
-        axisRange: 'auto',
       });
     });
     it('should construct a link with the correct params - daily top N', () => {
@@ -938,7 +936,6 @@ describe('constructAddQueryToDashboardLink', () => {
         yAxis: ['count()'],
         limit: 5,
         source: DashboardWidgetSource.DISCOVERV2,
-        axisRange: 'auto',
       });
     });
   });

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,6 @@ export function convertWidgetToBuilderStateParams(`
`76`	`76`	`selectedAggregate: firstWidgetQuery?.selectedAggregate,`
`77`	`77`	`thresholds: widget.thresholds ? serializeThresholds(widget.thresholds) : undefined,`
`78`	`78`	`traceMetric: traceMetric ? serializeTraceMetric(traceMetric) : undefined,`
`79`		`- axisRange: getAxisRange(widget.axisRange) ?? 'auto',`
	`79`	`+ axisRange: getAxisRange(widget.axisRange),`
`80`	`80`	`};`
`81`	`81`	`}`