fix(rrdom): Ignore invalid DOM attributes when diffing #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered an issue where replays with invalid attributes (e.g. `@click`) would break rendering the replay after seeking. The exception bubbles up to [here](https://github.com/rrweb-io/rrweb/blob/62093d4385a09eb0980c2ac02d97eea5ce2882be/packages/rrweb/src/replay/index.ts#L270-L279), which means the replay will continue to play, but the replay mirror will be incomplete.
c298lee
approved these changes
Aug 16, 2024
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Aug 27, 2024
* [fix(rrdom): Ignore invalid DOM attributes when diffing](getsentry/rrweb#213) * [fix: manual snapshot in rAF loop](getsentry/rrweb#210) (thanks @ShinyChang) * [feat: Fix blocking dynamically added iframes](getsentry/rrweb#212)
This was referenced Aug 27, 2024
billyvg
added a commit
that referenced
this pull request
Aug 27, 2024
We encountered an issue where replays with invalid attributes (e.g. `@click`) would break rendering the replay after seeking. The exception bubbles up to [here](https://github.com/rrweb-io/rrweb/blob/62093d4385a09eb0980c2ac02d97eea5ce2882be/packages/rrweb/src/replay/index.ts#L270-L279), which means the replay will continue to play, but the replay mirror will be incomplete. Closes getsentry/team-replay#458
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Aug 27, 2024
* [fix(rrdom): Ignore invalid DOM attributes when diffing](getsentry/rrweb#213) * [fix: manual snapshot in rAF loop](getsentry/rrweb#210) (thanks @ShinyChang) * [feat: Fix blocking dynamically added iframes](getsentry/rrweb#212)
billyvg
added a commit
that referenced
this pull request
Sep 17, 2024
* fix(rrdom): Ignore invalid DOM attributes when diffing (#213) We encountered an issue where replays with invalid attributes (e.g. `@click`) would break rendering the replay after seeking. The exception bubbles up to [here](https://github.com/rrweb-io/rrweb/blob/62093d4385a09eb0980c2ac02d97eea5ce2882be/packages/rrweb/src/replay/index.ts#L270-L279), which means the replay will continue to play, but the replay mirror will be incomplete. Closes getsentry/team-replay#458 * add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered an issue where replays with invalid attributes (e.g.
@click) would break rendering the replay after seeking. The exception bubbles up to here, which means the replay will continue to play, but the replay mirror will be incomplete.Closes https://github.com/getsentry/team-replay/issues/458