Update requests dependency to the version of 2.22.0 or higher#584
Merged
markstory merged 2 commits intogetsentry:masterfrom Sep 6, 2022
Merged
Update requests dependency to the version of 2.22.0 or higher#584markstory merged 2 commits intogetsentry:masterfrom
requests dependency to the version of 2.22.0 or higher#584markstory merged 2 commits intogetsentry:masterfrom
Conversation
beliaev-maksim
changed the title
requests dependency to the version of 2.23.0 or higherrequests dependency to the version of 2.22.0 or higher
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #584 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 2730 2730
=========================================
Hits 2730 2730 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
library since a long time requires "urllib3>=1.25.10"
if we looks at
requestssource code for v2.21.0 https://github.com/psf/requests/releases/tag/v2.21.0we will see that they require 'urllib3>=1.21.1,<1.25',
https://github.com/psf/requests/blob/5a1e738ea9c399c3f59977f2f98b083986d6037a/setup.py#L47
thus, update our dependency to the higher requests. Docs as well