fix(ourlog): use sentry prefix for browser name/version - #4783
Merged
Conversation
Dav1dde
approved these changes
May 30, 2025
k-fish
approved these changes
May 30, 2025
AbhiPrasad
added a commit
to getsentry/sentry
that referenced
this pull request
Jun 2, 2025
andrewshie-sentry
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4757 we decided to attach browser name and version to logs.
Right now for spans, we prefix browser information with
sentry.X, see https://github.com/getsentry/sentry/blob/34c738613c9b39e3b0d64336d13b4551a4075c66/src/sentry/search/eap/spans/attributes.py#L334.This is causing inconsistencies between the queries for spans and logs, which is breaking the current queries for the logs view. Considering we are "enhancing" the data via relay, I think it makes sense to also add a
sentry.Xprefix for logs. This PR makes that change.resolves https://linear.app/getsentry/issue/LOGS-152