fix(protocol): Flatten Linux distribution fields into os.context#4292
fix(protocol): Flatten Linux distribution fields into os.context#4292JoshuaMoelans merged 2 commits intomasterfrom
os.context#4292Conversation
|
I'm not sure if this is a skip-changelog kind of situation; the previous (non-flattened) implementation is listed as a feature under 24.4.1 , so maybe this update should be labelled as a |
jjbayer
left a comment
There was a problem hiding this comment.
Why does it need to be flattened to become searchable? Could we fix this on the storage end instead of changing the schema?
@JoshuaMoelans have SDKs already been sending the nested format? In that case, we need to still accept the nested format and normalize it into the flat format. |
|
@jjbayer no, since we never merged & released the sentry-native PR we have not been sending these nested format events. |
In that case I'm running out of objections 😄. Please add a |
os.context
<!-- Describe your PR here. --> update to #69865 To search the distribution fields, we cannot have them in a hierarchy `os.distribution.name`, we instead need them flattened to `os.distribution_name` This is part of reworking the following native-SDK PR: getsentry/sentry-native#963 The update is also tracked on the docs side: getsentry/sentry-docs#11936 And on Relay: getsentry/relay#4292
<!-- Describe your PR here. --> update to #69865 To search the distribution fields, we cannot have them in a hierarchy `os.distribution.name`, we instead need them flattened to `os.distribution_name` This is part of reworking the following native-SDK PR: getsentry/sentry-native#963 The update is also tracked on the docs side: getsentry/sentry-docs#11936 And on Relay: getsentry/relay#4292
(continuation of #3443 )
To make these fields searchable, we had to change from a nested to a flattened approach. This is provided in sentry-native (relevant PR).
The update is also tracked on the docs side: getsentry/sentry-docs#11936