feat(general): Don't fail events containing a span with missing timestamp#1690
Merged
Conversation
jjbayer
reviewed
Dec 13, 2022
jjbayer
left a comment
jjbayer
left a comment
Member
There was a problem hiding this comment.
Looks good to me, just two minor comments.
TBS1996
changed the title
TBS1996
changed the title
jjbayer
approved these changes
Dec 13, 2022
jjbayer
left a comment
jjbayer
left a comment
Member
There was a problem hiding this comment.
Please add a changelog as discussed, apart from that, this looks good!
jan-auer
changed the title
jan-auer
reviewed
Dec 13, 2022
jan-auer
approved these changes
Dec 14, 2022
TBS1996
changed the title
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If theres a missing timestamp on a span, it will get the timestamp of the event it belongs to, and it will get the status of DeadlineExceeded. Check issue for more info
Ref #1244