Conversation
commit 1c5740113b71435d1f24d05e33039fe35f7f7277 Author: Christopher Ferris <[email protected]> Date: Wed Sep 6 14:09:01 2023 -0700 https://android.googlesource.com/platform/system/unwinding
markushi
approved these changes
Sep 14, 2023
Member
markushi
left a comment
markushi
left a comment
There was a problem hiding this comment.
Looks good to me! I guess the automated tests are running as part of sentry-native, right?
Collaborator
Author
Yup... but I always test this manually as well because devices (but it would be better to have automated tests on a device farm, which the Native SDK tests are very far from). This PR has practically no side effect for our usage; I regularly look at upstream and merge occasionally to avoid letting the diff accumulate (in case there is a more significant diff). If there were changes that I worry about, I would stress this in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing with:
commit 1c5740113b71435d1f24d05e33039fe35f7f7277
Author: Christopher Ferris [email protected]
Date: Wed Sep 6 14:09:01 2023 -0700
https://android.googlesource.com/platform/system/unwinding
Summary of changes:
FormatFrameanywhere, so I didn't change that for now)