fix: Use the correct syscall for process_vm_readv#4
Merged
Conversation
Author
|
The needed functions were added in https://android.googlesource.com/platform/bionic/+/be57a40 which is Android API 23 (M) |
ghost
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that some code added in ivanarh@af11b0c#diff-3110c28650da71aad0da90c7564871442ba3651cdb2e3eed5f14b85007568c97R295 and 453f55d#diff-3110c28650da71aad0da90c7564871442ba3651cdb2e3eed5f14b85007568c97R27 was wrong and the calls to
process_vm_readvwere incorrect, and the code retried using a straight memcpy, which possibly lead to some segfaults.The new changes use the exported function directly on newer Android releases, and create a functioning wrapper for older Android versions.