Repository navigation
fix(junior-github): validate bot identity env vars in beforeToolExecute - #1566
Merged
dcramer merged 1 commit intoAug 14, 2026
Merged
Conversation
|
@myukitty is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
![sentry-junior[bot]](https://avatars.githubusercontent.com/in/2960336?s=60&v=4){kind=small}
dcramer
approved these changes
Aug 14, 2026
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1546.
When
GITHUB_APP_BOT_NAMEorGITHUB_APP_BOT_EMAILwas unset,beforeToolExecutein@sentry/junior-githubsilently returned early, leaving Git committer and author environment variables unpopulated. Downstream git commits then failed cryptically inside theprepare-commit-msggit hook with an internal configuration error.Changes
packages/junior-github/src/plugin.ts(beforeToolExecute):readEnvwithrequireEnvforbotNameEnvandbotEmailEnv.GitHubPluginSetupError("Missing GITHUB_APP_BOT_NAME")early before any broken tool execution.packages/junior-github/tests/github-plugin.test.ts:GitHubPluginSetupErroris thrown when bot identity environment variables are missing.Testing
packages/junior-github/tests/github-plugin.test.tspass cleanly.