Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Comments

Update UI Event Transaction the same event same ui element scenario#856

Merged
krystofwoldrich merged 3 commits intomasterfrom
kw-ui-event-transactions-update
Mar 6, 2023
Merged

Update UI Event Transaction the same event same ui element scenario#856
krystofwoldrich merged 3 commits intomasterfrom
kw-ui-event-transactions-update

Conversation

@krystofwoldrich
Copy link
Contributor

Based on the discussion here:

I think we should update the develop docs and open issues for SDKs that already implemented the current scenarios to update it.

@vercel
Copy link

vercel bot commented Mar 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
develop ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 0:33AM (UTC)

@krystofwoldrich krystofwoldrich changed the title chore(ui-event-transactions): Change the same event same ui element Update UI Event Transaction the same event same ui element scenario Mar 2, 2023
Copy link
Contributor

@0Calories 0Calories left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These scenarios look good to me, thanks @krystofwoldrich !

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the develop docs accordingly, @krystofwoldrich 👏 . A few issues to address.

@krystofwoldrich
Copy link
Contributor Author

krystofwoldrich commented Mar 3, 2023

@philipphofmann Thanks for the meta issue and for the suggestions.

Given an ongoing UI event transaction
When the user triggers the same UI element with a new event
Or the user triggers a different UI element
Then the SDK discards the transaction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krystofwoldrich what does "discard" mean exactly here? Does it mean finish the previous transaction as cancelled/aborted or does it mean drop the transaction or does it mean finish it normally but remove from scope? I guess this needs clarification

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this should be more explicit, so there can't be multiple ways of interpreting it.
The way I understood it was not to sample/drop the transaction.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants