Conversation
This particular action was crashing when being traced. Bug: fuchsia:68780 Change-Id: Ia83d48b2a88f53bd8e139ea9c787429f93a24533 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2662398 Commit-Queue: Scott Graham <[email protected]> Reviewed-by: Scott Graham <[email protected]>
Bug: crashpad: 31 Change-Id: I9149879b2f6886ea17ca828dd60d37eb187ba88e Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2665887 Commit-Queue: Justin Cohen <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
The previous error suppression in https://crrev.com/c/2662398 was not sufficient to disable action tracing (see https://fuchsia.dev/fuchsia-src/development/build/hermetic_actions?hl=en) Bug: fuchsia:68780 Change-Id: I587a71e01a13f863dceb548d09227ea3400e31b0 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2668015 Reviewed-by: Scott Graham <[email protected]> Commit-Queue: Scott Graham <[email protected]>
This method should be called when an application is ready to start processing previously created intermediate dumps and begin uploading. Processing will block, so this should not be called on the main UI thread. Bug: crashpad: 31 Change-Id: I31f81c68694cf18dd40e2994c0d6e7107c29e553 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2673024 Commit-Queue: Justin Cohen <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
This makes it possible to run gn check --deps for crashpad/snapshot in
chromium.
ERROR at //third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_fuzzer.cc:19:11: Can't include this header from here.
#include "util/process/process_memory.h"
^----------------------------
Bug: chromium:1159035
Change-Id: Idddcf95da2a349842fa86a8d595216fbca3b8822
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2676581
Commit-Queue: Mark Mentovai <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Xcode 12.5 renamed __personality_routine to _Unwind_Personality_Fn in usr/include/unwind.h Bug: crashpad:31 Change-Id: I06a9cec7f94556dfd7c1f729069c93c61b4b0d9c Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2686121 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Justin Cohen <[email protected]>
Bug: chromium:911896 Change-Id: I39d4356be8ba0c0fd8a4840d24b9eb0e83acc42d Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2719888 Commit-Queue: Jan Wilken Dörrie <[email protected]> Commit-Queue: Mark Mentovai <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
Use SIMULATOR_MODEL_IDENTIFIER to get the equivalent device model. Bug: crashpad:31 Change-Id: I17950d77c214533614781a5ca41170d6c3a77ae3 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2726978 Commit-Queue: Justin Cohen <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
2 commits: 0e081e6 Wrap python build script in __main__ guard 919fe9b Change non-Windows base::string16 to std::u16string Change-Id: I1a9aba56271a811559fe29c4741100aaf6642f0d Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2728775 Commit-Queue: Mark Mentovai <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
This CL[1] removed the alias declaration for wchar_t in case of Windows platform. So we cannot call base::UTF16ToUTF8 function with wchar_t type. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1776026 BUG=chromium:1184955 Change-Id: I07f0e35176ed72df4053d2f70769166e3eebfc63 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2737079 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mark Mentovai <[email protected]>
This method should be called when an application is ready to start uploading any pending reports. Bug: crashpad: 31 Change-Id: I70948fc4dfd8ee509d313b27a50fc4314baf5ce8 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2698179 Reviewed-by: Justin Cohen <[email protected]> Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Justin Cohen <[email protected]>
…ac3bf0 (2 commits) https://chromium.googlesource.com/chromium/mini_chromium/+log/0e081e6a0a33..0dcac3bf03a1 $ git log 0e081e6a0..0dcac3bf0 --date=short --no-merges --format='%ad %ae %s' 2021-03-08 jdoerrie Fix breakages introduced by std::u16string switch 2021-03-08 jdoerrie Change string16 to std::u16string everywhere Created with: roll-dep crashpad/third_party/mini_chromium/mini_chromium Bug: chromium:911896 Change-Id: Icac88b97b459b06ef86b292b1c5a785734d8f829 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2742824 Commit-Queue: Jan Wilken Dörrie <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
This change removes usages of the base::char16 and base::string16 type aliases in favor of using char16_t and std::u16string directly. Bug: chromium:1184339 Change-Id: Ieb790cbe2ce98d91865cd21d98616195a57b3903 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2742482 Commit-Queue: Jan Wilken Dörrie <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
…ca82f7 (1 commit) https://chromium.googlesource.com/chromium/mini_chromium/+log/0dcac3bf03a1..329ca82f73a5 $ git log 0dcac3bf0..329ca82f7 --date=short --no-merges --format='%ad %ae %s' 2021-03-15 jdoerrie Remove base::char16 and base::string16 Created with: roll-dep crashpad/third_party/mini_chromium/mini_chromium Bug: chromium:1184339 Change-Id: I414217a880a9267bf2693fd80f3097c208d2aeaf Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2760344 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Jan Wilken Dörrie <[email protected]>
Bug: fuchsia:65068 Test: Ran crashpad-test on device. Test: fx shell crashpad_database_util Change-Id: I4192030623fc85da9215039424e0bbec7eef8e30 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2758252 Reviewed-by: Scott Graham <[email protected]> Commit-Queue: Scott Graham <[email protected]>
Adds an overview of the limitations of crashpad on the iOS platform, including explanations of the in-process client and handler, and the intermediate dump format used. Bug: crashpad: 31 Change-Id: I1eb6add115570147e2de1be1002c5a4aa366184b Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2706018 Commit-Queue: Justin Cohen <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
Change-Id: I401c597c3c81c257d25e9e8a5e542521f52142dd Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2785784 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Justin Cohen <[email protected]>
Also fixes a usage of ->assign in the class which will be unsafe to use. Bug: crashpad:31 Change-Id: I434df35b0669dde2323817f3c0cef1727926c85f Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2650088 Commit-Queue: Justin Cohen <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
Bug: chromium:1077284 Change-Id: I19eed6072dd7854b81f7fa8c25470b18b3bc1ffd Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2037803 Commit-Queue: Joshua Peraza <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
This is a reland of b579146695ba0c045d26b022e63d199bd23f8349 Original change's description: > Default to the threadsafe GTest death_test_style. > > Using the default style of "fast" can lead to subtle test flakiness. > And on macOS, most of CoreFoundation is not safe to use after fork() > without exec(). Several //base implementations on Mac use CF, and so it > is almost never safe to use the "fast" death_test_style. > > Change-Id: Idcee977978561e0a57ace20b53f597c566708692 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/570500 > Commit-Queue: Robert Sesek <[email protected]> > Reviewed-by: danakj <[email protected]> > Reviewed-by: Gabriel Charette <[email protected]> > Cr-Commit-Position: refs/heads/master@{#854588} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2747682 Reviewed-by: Sophie Chang <[email protected]> Reviewed-by: Gabriel Charette <[email protected]> Reviewed-by: danakj <[email protected]> Commit-Queue: Robert Sesek <[email protected]> Cr-Commit-Position: refs/heads/master@{#862111} Message-Id: Merged from chromium b374bd6f372ac3ead20ed8b3a53ad1b60bd26b50 Change-Id: I87eae51cb4746183951bf8643f241937b119fa70 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2818148 Reviewed-by: Mark Mentovai <[email protected]>
The //build/confic/mac/BUILD.gn which defines this target does not build properly in some cronet ios build configurations, and the dependency is not necessary for ios builds. Fixed: 1161219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2656759 Commit-Queue: Ken Rockot <[email protected]> Auto-Submit: Ken Rockot <[email protected]> Reviewed-by: Robert Sesek <[email protected]> Cr-Commit-Position: refs/heads/master@{#848224} Message-Id: Merged from chromium a9f64a9dbf42e411a38e3c93b131984a0a02a84a Change-Id: Ifd03c41d42b3756cb77bb7cc3ece5d3f23b1262d Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2818147 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Robert Sesek <[email protected]>
flub
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.