feat: Support optional usage of stack pointer for captured stack frame#137
Merged
feat: Support optional usage of stack pointer for captured stack frame#137
Conversation
mujacica
force-pushed
the
feat/stack_limit_sp
branch
from
584fd63 to
94636a4
Compare
supervacuus
requested changes
Oct 27, 2025
Collaborator
supervacuus
left a comment
supervacuus
left a comment
There was a problem hiding this comment.
Generally fine with the change, given that it is optional anyway. Minor topics that we can improve.
supervacuus
approved these changes
Oct 28, 2025
JoshuaMoelans
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handling an exception, the Crashpad handler will scan all modules in a process. The first one that has a CrashpadInfo structure populated with a value other than TriState::kUnset for this field will dictate whether stack capture is adjusted.
This causes Crashpad to calculate stack capture range based on the current stack pointer instead of using TEB StackLimit/StackBase values. This is useful when running under Wine/Proton where TEB values may be incorrect.
More info: https://github.com/ValveSoftware/wine/blob/8b5ff79bcef26007edd5f1f517ba823f56c01bf3/dlls/dbghelp/minidump.c#L102
Tracking parent PR: getsentry/sentry-native#1427