Skip to content

feat: Add fastlane target#186

Closed
HazAT wants to merge 1 commit into
masterfrom
feat/fastlane
Closed

feat: Add fastlane target#186
HazAT wants to merge 1 commit into
masterfrom
feat/fastlane

Conversation

@HazAT

@HazAT HazAT commented Mar 2, 2021

Copy link
Copy Markdown
Member

No description provided.

@chadwhitacre

Copy link
Copy Markdown
Contributor

Is this still worth keeping open, @HazAT?

@HazAT

HazAT commented Sep 6, 2021

Copy link
Copy Markdown
Member Author

For context, this PR was meant to be used for releasing our Mobile app with the new workflow. But this is a very early entry point and a lot of things need to be figured out to get there.

@kamilogorek

Copy link
Copy Markdown
Contributor

I'll let myself close this for the sake of keeping this repo clean, but will remember about it if we ever decide to do fastlane.

@BYK
BYK deleted the feat/fastlane branch November 25, 2025 00:02
BYK added a commit that referenced this pull request Jul 1, 2026
## Summary

Resolves 3 Dependabot alerts (**#186, #187, #188**), all the same
advisory across both projects.

- **Advisory:**
[GHSA-h67p-54hq-rp68](GHSA-h67p-54hq-rp68)
/ CVE-2026-53550 — *js-yaml: Quadratic-complexity DoS in merge key
handling via repeated aliases* (medium severity)
- **Vulnerable:** \`>= 4.0.0, <= 4.1.1\` → **patched:** \`4.2.0\`

These alerts were opened by the post-merge rescan right after #839
landed (newly-published advisory), not caused by that change.

## Fix

| Alert | Manifest | Relationship | Change |
|---|---|---|---|
| #187 | root \`package.json\` | direct devDep | bump pinned \`js-yaml\`
\`4.1.1\` → \`4.2.0\` |
| #188 | root \`pnpm-lock.yaml\` | direct devDep | regenerated →
\`4.2.0\` |
| #186 | \`docs/pnpm-lock.yaml\` | transitive (astro/starlight) |
\`pnpm.overrides\` \`js-yaml: ^4.2.0\` → resolves to \`4.3.0\` |

- Root uses an exact pin (matching the repo's pinned-devDep convention,
e.g. \`tar\`); docs uses an override (matching the docs override style)
since js-yaml is transitive there.
- Both lockfile diffs are 100% js-yaml-scoped — no unrelated drift. No
\`@babel/core\`/other packages touched.

## Verification

- Root: \`pnpm build\` ✅, \`pnpm test\` ✅ (1025 passed, 1 skipped),
\`pnpm lint\` ✅ (0 errors), \`pnpm format:check\` ✅ (tracked files)
- Docs: \`pnpm build\` ✅ (27 pages built)
- \`grep "js-yaml@" pnpm-lock.yaml docs/pnpm-lock.yaml\` — only
\`4.2.0\`/\`4.3.0\` remain; \`4.1.1\` gone. (\`@types/js-yaml\` is
type-defs only, not the vulnerable package.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants