docs: Add toc entries for post-release script#165
Merged
Conversation
chadwhitacre
force-pushed
the
cwlw/small-toc-update
branch
from
January 15, 2021 21:07
5bac514 to
62e86dd
Compare
BYK
approved these changes
Jan 16, 2021
BYK
added a commit
that referenced
this pull request
Jun 10, 2026
## Summary Resolves the **2 open critical Dependabot alerts** (#165 and #166) for `shell-quote`. | Alert | Manifest | GHSA | Severity | |-------|----------|------|----------| | #165 | `package.json` | GHSA-w7jw-789q-3m8p | Critical | | #166 | `pnpm-lock.yaml` | (same) | Critical | `shell-quote < 1.8.4` does not escape newlines in object `.op` values within `quote()`. Craft only uses `parse()` on developer-controlled config strings (`.craft.yml` pre/post-release commands), so it was **not actually exploitable** — but the bump clears the alerts. ## Changes - **`package.json`**: `shell-quote` `1.7.3` → `^1.8.4` - **`pnpm-lock.yaml`**: regenerated (resolves `1.8.4`) - **`src/commands/publish.ts`**: normalized `import shellQuote from 'shell-quote'` → `import * as shellQuote from 'shell-quote'` to match `prepare.ts` (correct form for a CJS module with no default export) No breaking changes to `parse()` or the `ParseEntry` type between 1.7.3 and 1.8.4. ## Verification - `pnpm build` ✅ - `pnpm test` ✅ (972 passed; the 7 `prepare-dry-run.e2e` failures are a pre-existing env issue — `EDITOR` unset in headless CI — unrelated to this change) - `pnpm lint` ✅ (0 errors)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #144.