feat(publish): Add optional post-release script#144
Conversation
This PR adds an optional post-release script which is needed for projects like [getsentry/sentry](https://git.io/JIs4n) and [getsentry/onpremise](https://git.io/JIs4l). This would help keeping the common publish/release repo and its downstream project independent.
chadwhitacre
left a comment
chadwhitacre
left a comment
There was a problem hiding this comment.
I like the feature. It makes sense to support the specific use case of bumping the version post-release, and in general as a parallel to the pre-release hook. That said, this PR has the speed/quality dial set pretty far on "speed." I'm approving in case "speed" is where we want the dial set. If we want to turn the dial more towards quality and take on less tech debt, here are some suggestions:
- Refactor to deduplicate code between
runPreReleaseCommandandrunPostReleaseCommand. - Test the post-release command hook in the test suite. There are tests for the pre-release hook. Either duplicate or refactor, based on decision under (1).
- Update the documentation in the README. There's a section for the pre-release script; either duplicate or refactor.
|
@chadwhitacre will address points 2 and 3 in your feedback before merging, thanks a lot! (I may take a stab at 1 but no promises). |
|
I need another review, especially for the README changes. @chadwhitacre - I've opted not to refactor/DRY the common parts in script runners as the optional nature of the |
chadwhitacre
left a comment
chadwhitacre
left a comment
There was a problem hiding this comment.
Couple doc nits, otherwise lgtm.
Co-authored-by: Chad Whitacre <[email protected]>
4 participants
This PR adds an optional post-release script which is needed for
projects like getsentry/sentry and
getsentry/onpremise. This would help keeping
the common publish/release repo and its downstream project independent.