Skip to content

Components without selectors will have a default one assigned#106

Merged
getsaf merged 2 commits intogetsaf:masterfrom
duck-nukem:components-without-selector
Apr 18, 2019
Merged

Components without selectors will have a default one assigned#106
getsaf merged 2 commits intogetsaf:masterfrom
duck-nukem:components-without-selector

Conversation

@duck-nukem
Copy link
Collaborator

@duck-nukem duck-nukem commented Apr 17, 2019

Should fix #105

Draft PR to showcase the idea, code style and test is debatable

@duck-nukem duck-nukem self-assigned this Apr 17, 2019
…ctor

Reverted a broader fix for the same issue
@duck-nukem duck-nukem marked this pull request as ready for review April 17, 2019 13:14
@getsaf getsaf merged commit 04005f6 into getsaf:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProxyShallowContainer creates <undefined ></undefined> without a selector in the Component

2 participants