Query Parameter documentation updates#195
Merged
Merged
Conversation
ghost
assigned
ranbena
reviewed
Feb 12, 2019
ranbena
reviewed
Feb 12, 2019
ranbena
reviewed
Feb 12, 2019
ranbena
left a comment
ranbena
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Left some comments 👍
ranbena
reviewed
Feb 12, 2019
| + **Value Source** is where you choose your preferred mapping. Click the pencil glyph to open the mapper settings. | ||
|
|
||
| ### Value Source Options | ||
|
|
Contributor
There was a problem hiding this comment.
Do you think value source popover screenshot would be beneficial here?
Contributor
Author
There was a problem hiding this comment.
Good thinking. I will add this as well.
arikfr
reviewed
Feb 12, 2019
Member
|
Because we released this already I didn't want this to wait any longer. I did a few changes (updated text re. default value and callout about version) and going to merge this. Let's have a follow up with Ran's other comments. Also I think we should have a word on how this used to work (the global checkbox) and how existing dashboards transition into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes updates reflecting the new dashboard parameter UX in version 7. Also includes minor tweaks to the introductory paragraph.