Skip to content

Changed viz embed download menu to drop up#3696

Merged
ranbena merged 1 commit into
masterfrom
dropup
Apr 10, 2019
Merged

Changed viz embed download menu to drop up#3696
ranbena merged 1 commit into
masterfrom
dropup

Conversation

@ranbena

@ranbena ranbena commented Apr 10, 2019

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Bug Fix

Description

Embeds show up in iframes which will cut off the overflowing dropdown menu.
So, made it drop up.

Mobile & Desktop Screenshots

Before After
Screen Shot 2019-04-10 at 10 33 05 Screen Shot 2019-04-10 at 10 31 35

@ranbena
ranbena merged commit 70227f2 into master Apr 10, 2019
@ranbena
ranbena deleted the dropup branch April 10, 2019 08:02
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants