Skip to content

Add package-lock.json after including qs#3695

Merged
rauchy merged 1 commit into
masterfrom
package-json-for-qs-dependency
Apr 10, 2019
Merged

Add package-lock.json after including qs#3695
rauchy merged 1 commit into
masterfrom
package-json-for-qs-dependency

Conversation

@rauchy

@rauchy rauchy commented Apr 10, 2019

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@rauchy
rauchy requested a review from arikfr April 10, 2019 07:23
@kravets-levko kravets-levko changed the title add package.json after including qs Add package-lock.json after including qs Apr 10, 2019
@kravets-levko

Copy link
Copy Markdown
Collaborator

@rauchy I see that npm installed qs of the same version few times. Usually it happens when you add dependency to the project, but one of existing dependencies already have it. Try to remove node_modules, run npm install and see if it helps to remove duplicates.

@rauchy

rauchy commented Apr 10, 2019

Copy link
Copy Markdown
Contributor Author

@kravets-levko that's interesting. I tried doing it and it had no effect though :(

@kravets-levko kravets-levko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems other qs are related to webpack-dev-server, so looks fine 👍

@rauchy
rauchy merged commit 9fcf510 into master Apr 10, 2019
@rauchy
rauchy deleted the package-json-for-qs-dependency branch April 10, 2019 08:26
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants