Conversation
Contributor
Author
Contributor
Author
Member
|
An issue I noticed here: X button is always visible. |
Member
|
I'm still mind blown that all of this niceness is implemented mostly with CSS. Looks like magic to me. 🤯 |
ranbena
force-pushed
the
tile
branch
2 times, most recently
from
April 22, 2019 07:43
63d68a7 to
2918194
Compare
kravets-levko
approved these changes
Apr 23, 2019
kravets-levko
left a comment
kravets-levko
left a comment
Collaborator
There was a problem hiding this comment.
Looks good 👍 Percy says that there is an extra padding on dashboard page, but seems its not an issue.
Member
|
Should we merge this now? @ranbena |
10 tasks
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
This was referenced Sep 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Added grid tile markings to dashboard edit mode.
Discussion in https://discuss.redash.io/t/dashboard-grid-markings/3515.
Reviewer 👋
Mobile & Desktop Screenshots