Skip to content

Fix a few more inconsistencies when loading and dumping JSON.#3626

Merged
arikfr merged 2 commits into
masterfrom
json_api
Mar 27, 2019
Merged

Fix a few more inconsistencies when loading and dumping JSON.#3626
arikfr merged 2 commits into
masterfrom
json_api

Conversation

@jezdez

@jezdez jezdez commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Bug Fix

Description

These change have been added since c2429e9.

Related Tickets & Documents

Refs #2807. Original work in: #2817

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Refs #2807. Original work in: #2817

These change have been added since c2429e9.
@jezdez jezdez added this to the v7.0.0 milestone Mar 22, 2019
@ghost ghost assigned jezdez Mar 22, 2019
@ghost ghost added the in progress label Mar 22, 2019

@arikfr arikfr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Comment thread redash/authentication/jwt_auth.py Outdated
@jezdez
jezdez requested a review from arikfr March 27, 2019 14:25
@jezdez jezdez modified the milestones: v7.0.0, Next Mar 27, 2019
@arikfr
arikfr merged commit 77c5313 into master Mar 27, 2019
@arikfr
arikfr deleted the json_api branch March 27, 2019 15:14
@arikfr

arikfr commented Mar 27, 2019

Copy link
Copy Markdown
Member

Thanks.

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
…ash#3626)

* Fix a few more inconsistencies when loading and dumping JSON.

Refs getredash#2807. Original work in: getredash#2817

These change have been added since c2429e9.

* Review fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants