Fix Celery worker --max-tasks-per-child for Celery 4.x.#3625
Merged
Conversation
ghost
assigned
Contributor
Author
|
/cc @jasonthomas |
arikfr
reviewed
Mar 24, 2019
jezdez
commented
Mar 27, 2019
| worker() { | ||
| WORKERS_COUNT=${WORKERS_COUNT:-2} | ||
| QUEUES=${QUEUES:-queries,scheduled_queries,celery,schemas} | ||
| WORKER_EXTRA_OPTIONS=${WORKER_EXTRA_OPTIONS:} |
Contributor
Author
There was a problem hiding this comment.
@jasonthomas Is this a legitimate shell script?
There was a problem hiding this comment.
No, it is throwing a bad substitution error. It should be WORKER_EXTRA_OPTIONS=${WORKER_EXTRA_OPTIONS:-} instead.
arikfr
approved these changes
Mar 27, 2019
arikfr
left a comment
arikfr
left a comment
Member
There was a problem hiding this comment.
Looks good assuming the WORKER_EXTRA_OPTIONS thing is legit.
jasonthomas
approved these changes
Mar 27, 2019
Member
|
Thanks. |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* Fix Celery worker CLI parameter name that was changed in Celery 4.x. * Set Celery worker --max-memory-per-child to 1/4th of total system memory. * Review fixes. * Review fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This fixes the name of the
--max-tasks-per-childparameter whose name was changed in Celery 4.x and adds a--max-memory-per-childof 1/4 of total memory.Related Tickets & Documents
Port of mozilla#364