Add error message when destination name already exists#3597
Merged
Conversation
ghost
assigned
rauchy
reviewed
Mar 24, 2019
arikfr
requested changes
Mar 25, 2019
Co-Authored-By: gabrieldutra <[email protected]>
Co-Authored-By: gabrieldutra <[email protected]>
arikfr
approved these changes
Mar 27, 2019
Member
|
👍 |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* Return 400 when destination name already exists * Remove whitespace * Unicode 1 Co-Authored-By: gabrieldutra <[email protected]> * Unicode 2 Co-Authored-By: gabrieldutra <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
It was returning 500 with no message ("Failed saving." in frontend). It was necessary to guess that the error was due to name duplicity.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)