Migrate Admin pages to React#3568
Conversation
|
Wow 1st look, looks so good! 👏 Few things I noticed:
|
|
@ranbena Thanks! All fixed. |
|
Suggestion for future - make these into Redash built-in dashboards (grids, counts). 🤘 |
|
@ranbena That idea crossed my mind some time ago 🙂 We'll need some new visualization types for that. |
It could be a great forcing function to make better widgets and set an example to our clients. |
I agree. Let's start moving in this direction when our visualizations are pure React, so it's easier to create better APIs for them. :-) |
ranbena
left a comment
There was a problem hiding this comment.
LGTM.
@kravets-levko I don't have queue data but consider <Tabs animated={false}> if the tab change content animation is too crazy looking with actual data.
|
@ranbena Which tabs do you mean? There are top-level tabs ("System Status", "Celery Status", ...) and inner tabs on "Celery Status" tab. For top-level tabs I had to disable animation because that tabs are link, and when clicked - animation started, then component destroyed - so it looked really weird. For inner tabs animation doesn't look so weird. |
Celery tabs
Okey dokey |
|
Decided to disable animation - for consistency between top-level and inner tabs. |
|
@arikfr @gabrieldutra If you're fine with this - LMK if I can merge it. Thanks! |

What type of PR is this? (check all applicable)
Description
Mobile & Desktop Screenshots/Recordings (if there are UI changes)