@arikfr we spoke about this a few weeks ago. I think we should consider moving .eslintrc.js to the root folder of the repo.

It seems I missed some config for CodeClimate (it only caught my test for cypress). It also made eslint required for build. I'll need to check this more calmly.

How about instead git mv cypress client/?

How about instead git mv cypress client/?

This crossed my mind :-) But I thought that moving eslint configuration will be easier.

It also made eslint required for build.

It should be.

How about instead git mv cypress client/?

Would also make lint-staged config easier with "ignore":

  "lint-staged": {
    "linter": {
      "client/**/*.{js,jsx}": [
        "npm run lint:base",
        "npm run test -- --bail --findRelatedTests"
      ]
    },
    "ignore": ["client/dist/*"]
  }

rather than having to set two linter paths and repeating the config:

  "lint-staged": {
    "client/app/**/*.{js,jsx}": [
      "npm run lint:base",
      "npm run test -- --bail --findRelatedTests"
    ],
  "cypress/**/*.{js,jsx}": [
      "npm run lint:base",
      "npm run test -- --bail --findRelatedTests"
    ]
  }

@ranbena 👍

rather than having to set two linter paths and repeating the config:

Not sure this would be a good approach, but it did work 😅

"lint-staged": {
  "{client/app,cypress}/**/*.{js,jsx}": [
    "npm run lint:base",
    "npm run test -- --bail --findRelatedTests"
  ]
}

But I'll go with cypress in client folder option 😆

@arikfr this lgtm. You cool with this?

@arikfr I'd really like this to land asap.
Any suggestions on how to improve the config?

I didn't realize this was waiting for me. I just asked if there is another option :)
Feel free to merge when you & @gabrieldutra feel it's ready.

I'm going to merge this once CI is done, ongoing cypress' PRs will be affected @ranbena & @arikfr. There are some eslint issues in search_query_spec.js, I chose not to fix them in order to avoid diff issues :)

There are some eslint issues in search_query_spec.js, I chose not to fix them in order to avoid diff issues :)

Once merged, I'll rebase #3635 and fix the lint errors.