Skip to content

Make actions column fixed#3541

Closed
kravets-levko wants to merge 2 commits into
getredash:masterfrom
kravets-levko:fix/list-pages-table-scroll
Closed

Make actions column fixed#3541
kravets-levko wants to merge 2 commits into
getredash:masterfrom
kravets-levko:fix/list-pages-table-scroll

Conversation

@kravets-levko

@kravets-levko kravets-levko commented Mar 6, 2019

Copy link
Copy Markdown
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix

Description

Possible fix for #3521: make columns with action buttons fixed (see screenshots).

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image

image

@kravets-levko kravets-levko self-assigned this Mar 6, 2019
@ghost ghost added the in progress label Mar 6, 2019
@ranbena ranbena mentioned this pull request Mar 7, 2019
Merged
3 tasks
@ghost ghost assigned ranbena Mar 7, 2019
@ranbena

ranbena commented Mar 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@kravets-levko Even-though #3545, this PR could function as a fail-safe in case sth gets messed up. Wdyt?

@gabrieldutra

gabrieldutra commented Mar 7, 2019

Copy link
Copy Markdown
Member

@kravets-levko Even-though #3545, this PR could function as a fail-safe in case sth gets messed up. Wdyt?

This is currently being applied to mobiles, even though #3545:
mobile-users

@kravets-levko

kravets-levko commented Mar 7, 2019

Copy link
Copy Markdown
Collaborator Author

@gabrieldutra because, as I mentioned, fixing group labels is not enough - on narrow screens there will be scroll anyway.

@kravets-levko

kravets-levko commented Mar 7, 2019

Copy link
Copy Markdown
Collaborator Author

@ranbena

Even-though #3545, this PR could function as a fail-safe in case sth gets messed up. Wdyt?

While it fixes the bug perfectly, design-wise it's unappealing. 😁

@ranbena

ranbena commented Mar 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Mobile needs a different and dedicated layout. Currently, mobile doesn't work with or without the fixed col.
IMO, if it can be easily turned off for mobile - let's use it, if not - let's withdraw the idea.

@kravets-levko

kravets-levko commented Mar 7, 2019

Copy link
Copy Markdown
Collaborator Author

While this fix was one of possible options, I don't like it that much. Therefore I decided to close this PR. We should find a better solution for lists on small screens.

@ghost ghost removed the in progress label Mar 7, 2019
@weekly-digest weekly-digest Bot mentioned this pull request Mar 10, 2019
Closed
@kravets-levko
kravets-levko deleted the fix/list-pages-table-scroll branch March 10, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arikfr arikfr Awaiting requested review from arikfr
@ranbena ranbena Awaiting requested review from ranbena
@gabrieldutra gabrieldutra Awaiting requested review from gabrieldutra

Assignees

@ranbena ranbena

@kravets-levko kravets-levko

Labels

Bug Frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kravets-levko @ranbena @gabrieldutra @arikfr