Why is { force: true } needed?

@ranbena - the anchor tag is not actionable at that point (it's hidden away), so { force: true } clicks it anyway.

🚀

Hi Guys - thank you for the merge. What is the quickest way to get this into production? I usually pull the docker images from docker hub, but I guess this will not be there yet. Should I pull the preview tag?

@HenroRitchie you can use the redash/preview Docker repo and use a specific tag from there (once there is a master build with this PR).

@arikfr Thank you. Will just wait for the master build with this PR.

Hi Guys - I have attempted to embed a query into another page but I get an error response It seems like we encountered an error. Try refreshing this page or contact your administrator.

When embedding a dashboard it still works fine, without the parameters being available. Looking at the developer console in chrome the response from Redash is a 400 Bad Request. Should I continue the discussion here, or somewhere else?

@HenroRitchie generally we'd prefer support discussions at the forums but since this is a new feature it may be related directly to this ticket.

A 400 here could probably mean an incorrect parameter type passed in - could you check and also send over the response message that came along with that 400?

@rauchy I will continue here until we are sure my problem and this PR are unrelated.

I used the embed Embed elsewhere link to generate the iframe code. When I try to embed a query without any parameters this is the iframe code generated:

<iframe src="{{ $ctrl.embedUrl }}" width="720" height="391"></iframe>

This is clearly wrong. When I try to embed a query with parameters and use the Embed elsewhere link this is the result:

<iframe src="https://secret.url/embed/query/1/visualization/2?api_key=xd8wfBdBxsW8rB1jGxIgDySQhkQGBvLKfpiMPx9J&p_fridge_tag=fridge_1_top&p_date_range.start=2019-02-21%2000%3A00%3A00&p_date_range.end=2019-02-26%2000%3A00%3A00" width="720" height="391"></iframe>

If I just use the generated URI I get the same error response posted earlier.

The response message is: "message": "The following parameter values are incompatible with their definitions: date_range.start, date_range.end"}. I thus removed the date range parameter and now the embed works. However, when I select a different option in the embed the chart is not updated correctly. The chart defaults back to the initial setup, i.e. x-axis from -1 to 6 and y-axis from -1 to 4 without any data. Is the query automatically refreshed/run when the parameter value changed? Is looks like this is not the case. I first must run the query directly in Redash with the corresponding parameter selected before in will show correctly in the embed.

@HenroRitchie thanks for the details. You've helped me find 2 bugs which are fixed here and here. I'm assuming they will get merged today and I'll be looking to hear if they solved your problem.

@rauchy Thank you for the updates and commits. I am happy to report that I can now embed data parameters successfully. However, the queries are still not refreshed when any of the parameters change. In my test, I have one drop-down parameter and one date range parameter. I followed the steps below to test.

In Redash select the first parameter and the date range and run the query. I manually run the query every time. Check the results in Redash. Embed the query in the secondary portal as an Iframe. This works and provides the same results as Redash directly. If I now select a different parameter from the dropdown or change the date range the chart display defaults to the generic chart. Furthermore, if I attempt to download the CSV file it fails with a server error.

I monitored the Celery Status page - and it does seem that something is happening as soon as I change the parameter, but the page and chart are never updated. I don't know if the page is not updated with the latest info or if takes too long. I have a large number of data to display, and changing the first parameter might trigger the query but it takes such a long time that it never gets updated on the display. Visual feedback to show the query is being refreshed might help here.

Changing the refresh schedule to every 1 minute does not make a difference in the selected parameter set's displayed chart. I have found some strange behavior regarding the automatic refresh. If the refresh is set to 1 minute the selected parameter set and the corresponding chart does not get updated, but if the drop down parameter changes the new set's chart is correctly displayed. If you then select the previous set (which were not updated) it now shows the correct chart. It is as if the query is run, but the chart displayed is not updated unless reloaded/refreshed. Refreshing the browser does not work as it then loads the parameter as set in the query window in Redash directly.

How does Redash handle parameters with an automatic refresh schedule? Are queries run for all the different drop down options, or only for the active parameter set?

Lastly, am I approaching this correctly? Should the parameter change a variable in the SQL query, or should the variable filter the results? The difference is the amount of data sent from Postgres to Redash. Running the same query every time might be better for Redash, or will it not make a difference?

@rauchy Update

If parameter 1 option 1 is selected with a specific date range nothing happens.
If parameter 1 option 2 is selected with the same date range nothing happens.
If parameter 1 option 1 is selected with the same date range the correct chart is now available.
If parameter 1 option 2 is selected with the same date range the correct chart is available.
If parameter 1 option 3 is selected with the same date range nothing happens.
If parameter 1 option 1 is selected, and then option 3 again the chart is available.

Does this PR also cover embedding dashboards with parameters. I am now able to embed visualizations with params but dashboards with params are still not supported?