Add a data source description as hover text#3401
Closed
emtwo wants to merge 23 commits into
Closed
Conversation
added 23 commits
February 5, 2019 14:41
…ted or after a migration.
…tore/fetch sample queries.
ghost
assigned
This was referenced Feb 5, 2019
Merged
Member
|
Thanks, @emtwo, can you please:
It's really hard to review without it. |
Contributor
|
@emtwo , one more :) We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that. |
Member
|
This one's probably not useful as-is. It seems to require a series of other PRs to already be merged, some of which we've closed already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows an admin to add a description for a data source which is shown as hover text.
It is the fourth part of a series of PRs for schema enhancements. It is preceded by #3293
[1] Schema viewer drawer #3291
[2] Schema admin configuration #3292
[3] Schema query samples #3293
[4] Data source descriptions #3401 (This one)