Skip to content

[WIP] Closes #3192: Add data source config options. #3193

Closed
emtwo wants to merge 7 commits into
getredash:masterfrom
emtwo:datasource-config2
Closed

[WIP] Closes #3192: Add data source config options. #3193
emtwo wants to merge 7 commits into
getredash:masterfrom
emtwo:datasource-config2

Conversation

@emtwo

@emtwo emtwo commented Dec 14, 2018

Copy link
Copy Markdown

This builds on top of #2990 to allow the admin UI to modify table and column descriptions and visibility

@emtwo emtwo added the review label Dec 14, 2018
@arikfr

arikfr commented Dec 16, 2018

Copy link
Copy Markdown
Member

Should we review #2990 first and then this one, or this one completely replaces #2990?

@emtwo

emtwo commented Dec 16, 2018

Copy link
Copy Markdown
Author

#2990 would need to be reviewed first. The only new commit created in this PR is f9b82bd.

@emtwo
emtwo force-pushed the datasource-config2 branch from f9b82bd to 85b1c60 Compare December 17, 2018 15:12
@emtwo

emtwo commented Dec 19, 2018

Copy link
Copy Markdown
Author

Adding some screenshots to give an idea of what this PR does.

Essentially, this PR adds the ability to let an admin add table and column descriptions and decide whether a given table is visible or not. These modifications are then reflected in the schema viewer and schema drawer that was added in #2990

screen shot 2018-12-19 at 12 46 38 pm

screen shot 2018-12-19 at 12 52 04 pm

screen shot 2018-12-19 at 12 52 10 pm

screen shot 2018-12-19 at 12 53 04 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants