Support LDAP servers where one doesn't first have to bind to the LDAP server with a username/password#3002
Merged
Conversation
Bring up to date
Update from getredash/redash
… server with a username/password
Jakdaw
force-pushed
the
support-ldap-without-bind
branch
from
April 12, 2019 14:12
4d63f24 to
868d9ba
Compare
Contributor
Author
|
@arikfr Could this simple change please be merged? |
Member
|
Thanks. |
The-Alchemist
pushed a commit
to The-Alchemist/redash
that referenced
this pull request
Jul 17, 2019
… server with a username/password (getredash#3002) * Support LDAP servers where one doesn't first have to bind to the LDAP server with a username/password * Address code climate things
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
… server with a username/password (getredash#3002) * Support LDAP servers where one doesn't first have to bind to the LDAP server with a username/password * Address code climate things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch, for such LDAP servers one simply doesn't configure LDAP_BIND_DN and LDAP_BIND_DN_PASSWORD.