WIP: add API hook for schema browser display#2826
Closed
alison985 wants to merge 1 commit into
Closed
Conversation
|
This pull request is automatically deployed with Now. |
Contributor
Author
|
@jezdez Reminder ping on the javascript question. |
Member
|
I don't remember the name right now, but there is a function in Lodash that does exactly this (returns only the properties you defined from a Javascript object). While having support for different schema browser components makes sense, I don't think this is the case for it. To implement what's needed here it's enough to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue: mozilla#185
Original PR: mozilla#201
Issue to post this upstream: mozilla#430
Previous PR code reviews trying to port this upstream: #2655 #2764
Problem: This javascript forEach loop breaks the autoComplete feature/typing in the query textarea. Additional/random keys appear in it when typing. If you comment out this forEach loop the problem disappears. I have tried writing the loop different ways and this is the only one that really passes the linter. I have no idea why this interaction is occurring and would love any help or pointers in the right direction.
This PR: